On Mon, Jun 29, 2015 at 06:05:25PM +0300, Sagi Grimberg wrote: > Instead of open coding the sense buffer construction, use > scsi scsi_build_sense_buffer() and scsi_set_sense_information() > helpers. > > This patch also fixes wrong setting of descriptor format sense data > for t10-pi integrity errors.
This looks good in general, but we'd need to move this functions to the scsi common module first now that the target code doesn't use scsi_mod.ko. (Oh, for some reason 4.2 still builds scsi_common.c into scsi_mod.ko, but in the long run it shouldn't). Whie we're at it I'd also really love to Barts sense handling updates to go in: https://github.com/bvanassche/linux/commit/c8e3ccce0753522cff50987db8e411be2b452cdd https://github.com/bvanassche/linux/commit/50e0e2c6681091cda23e677fe9b6fbd2c70d99b1 https://github.com/bvanassche/linux/commit/02b27ec5c94117a976e16421556c1cb7287b6635 Bart, any chance you could resend them? -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
