Hello.

On 12/10/2014 4:43 AM, Karen Xie wrote:

[PATCH net v5 2/7] cxgb4i: fix credit check for tx_data_wr

From: Karen Xie <k...@chelsio.com>

make sure any tx credit related checking is done before adding the wr header.

Signed-off-by: Karen Xie <k...@chelsio.com>
---
  drivers/scsi/cxgbi/cxgb4i/cxgb4i.c |    9 +++++----
  1 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c 
b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
index f119a67..56dbd25 100644
--- a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
+++ b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
@@ -547,15 +547,16 @@ static inline void make_tx_data_wr(struct cxgbi_sock 
*csk, struct sk_buff *skb,
[...]
                req->op_to_immdlen = htonl(FW_WR_OP(FW_OFLD_TX_DATA_WR) |
-                                       FW_WR_COMPL(1) |
-                                       FW_WR_IMMDLEN(dlen));
+                                          FW_WR_COMPL(1) |
+                                          FW_WR_IMMDLEN(dlen));
                req->flowid_len16 = htonl(FW_WR_FLOWID(csk->tid) |
-                                               FW_WR_LEN16(credits));
+                                         FW_WR_LEN16(credits));

The above looks like unrelated cleanup, worth putting in a separate net-next patch...

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to