Am 03.12.2014 11:09, schrieb Dan Carpenter:
> The issue_reset variables were never set to zero.  This bug was found
> with static analysis.
> 
> Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>
> 
> diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c 
> b/drivers/scsi/mpt2sas/mpt2sas_base.c
> index 58e4521..98bd546 100644
> --- a/drivers/scsi/mpt2sas/mpt2sas_base.c
> +++ b/drivers/scsi/mpt2sas/mpt2sas_base.c
> @@ -3236,7 +3236,7 @@ mpt2sas_base_sas_iounit_control(struct MPT2SAS_ADAPTER 
> *ioc,
>       u16 smid;
>       u32 ioc_state;
>       unsigned long timeleft;
> -     u8 issue_reset;
> +     bool issue_reset = 0;
>       int rc;
>       void *request;
>       u16 wait_state_count;
> @@ -3341,7 +3341,7 @@ mpt2sas_base_scsi_enclosure_processor(struct 
> MPT2SAS_ADAPTER *ioc,
>       u16 smid;
>       u32 ioc_state;
>       unsigned long timeleft;
> -     u8 issue_reset;
> +     bool issue_reset = 0;
>       int rc;
>       void *request;
>       u16 wait_state_count;


hi Dan,
just a minor question:

did you forget to mention that you also changed from u8 to bool or was this 
unintentional ?

re,
 wh
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to