>On Tue, Oct 7, 2014 at 10:58 PM, Sagi Grimberg <sa...@dev.mellanox.co.il> >wrote: >>On 10/8/2014 3:41 AM, Jay Kallickal wrote: >>From: Jayamohan Kallickal <jayamoh...@gmail.com>
>> This patch allows the underlying hardware to choose >>values other than hard coded max values for cqe and send_wr >>while preventing them from exceeding max supported values. >Hi Minh and Jayamohan, >So I agree that we would want to take device capabilities into account >here, but we need to be able to adjust scsi_cmds_max (can_queue) in case >the max wqe supported is lower than scsi_cmds_max * num_posts_per_cmd. I feel we should be fine as long as we support the max_cmds of 128 supported by open-iscsi layer. I see the iser layer uses a value of 512 though it only serves as a limit check. >So generally I agree with this approach, but we need to take care of >stuff later when the session is created. >One more thing, this is not rebased on the latest iser patches please >send v1 on top of: http://marc.info/?l=linux-rdma&m=141216135013146&w=2 Yes, I will recreate the patch and send on top of this Resending: Looks like my response got dropped by the filters. Am travelling . Minh is working on the patches and would respond -Jay -- -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
