On 10/02/2014 01:22 PM, Christoph Hellwig wrote: >> diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c >> index a0c8c5d..cb68089 100644 >> --- a/drivers/scsi/NCR5380.c >> +++ b/drivers/scsi/NCR5380.c >> @@ -1527,7 +1527,6 @@ part2: >> tmp[0] = IDENTIFY(((instance->irq == SCSI_IRQ_NONE) ? 0 : 1), >> cmd->device->lun); >> >> len = 1; >> - cmd->tag = 0; > > The driver was explicitly setting the tag to zero here, so this needs > a good explanation instead of a blind removal. > > But given how nice the code that Finn delivered in the past is I have high > hopes that his NCR5380 overhaul will get rid of a lot of this cruft :) > Yep. (Removing the above line shouldn't actually doing any harm, as the tagged queueing support in NCR5380 is currently disabled anyway). (Famous last words).
But this was just a test for the feasibility of scmd->tag removal. Once Finn's patchset is posted we definitely should be revisiting it. And arguably the tcm_loop and vmw_pvscsi patches are real bugfixes, so maybe they should be applied anyway. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
