On 14-08-28 01:33 PM, Hannes Reinecke wrote:
Hi all,
here's my next round of scsi logging updates.
Main feature is the update to have all logging
statements in one line so that they won't be broken
up even under high load.
This will dramatically improve debugging.
Additionally all printk() statements are moved
to dev_printk() variants to ensure proper device
tagging and keep the systemd journal happy.
s/all/most/ ??
Surely there are situations where a "dev" cannot be
associated with a printk(). For example in transport
discovery before any devices are found (or after,
if none are found). LLDs often helpfully log their HBA's
firmware details prior to discovery (and may fail
before discovery).
And it is possible to write via sysfs to a driver
that has no devices attached. How does one log that?
Doug Gilbert
To achieve this I had to use a on-stack
buffer for formatting opcodes and sense codes;
so the stack usage will increase somewhat.
Reviews, comments etc are welcome.
Hannes Reinecke (22):
Remove scsi_cmd_print_sense_hdr()
aha152x: Remove #ifdef 0 section
sd: Remove scsi_print_sense() in sd_done()
scsi: introduce sdev_prefix_printk()
scsi: Use sdev as argument for sense code printing
scsi: stop decoding if scsi_normalize_sense() fails
scsi: do not decode sense extras
scsi: dump sense buffer only for debugging
Use sdev as argument for scsi_print_result
scsi: consolidate scsi_print_status()
Implement scsi_opcode_sa_name
scsi: remove obsolete __scsi_print_command() usages
scsi: use local buffer for printing the opcode
scsi: pass in string buffer to __scsi_print_command()
scsi: use dev_printk() variants in scsi_print_command()
libata: use __scsi_print_command()
scsi: print disposition in scsi_print_result()
scsi_error: format abort error message
scsi: use local buffer for scsi_log_(send|completion)
scsi: align logging messages
scsi: reduce messages for command failure
sd: Reduce logging output
drivers/ata/libata-eh.c | 12 +-
drivers/scsi/53c700.c | 3 +-
drivers/scsi/aha152x.c | 32 +--
drivers/scsi/arm/acornscsi.c | 9 +-
drivers/scsi/arm/fas216.c | 30 +--
drivers/scsi/ch.c | 7 +-
drivers/scsi/constants.c | 570 ++++++++++++++++++++----------------------
drivers/scsi/osst.c | 8 +-
drivers/scsi/scsi.c | 65 ++---
drivers/scsi/scsi_error.c | 68 ++---
drivers/scsi/scsi_ioctl.c | 2 +-
drivers/scsi/scsi_lib.c | 10 +-
drivers/scsi/sd.c | 28 ++-
drivers/scsi/sg.c | 9 +-
drivers/scsi/sr_ioctl.c | 16 +-
drivers/scsi/st.c | 13 +-
drivers/scsi/storvsc_drv.c | 3 +-
include/scsi/scsi_dbg.h | 34 +--
include/scsi/scsi_device.h | 5 +
include/trace/events/scsi.h | 17 +-
include/trace/events/target.h | 17 +-
21 files changed, 457 insertions(+), 501 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
