There is no need to print out the command result verbatim;
that will be done by the scsi stack if required.
Here we just should log the result in short if requested.

Signed-off-by: Hannes Reinecke <h...@suse.de>
---
 drivers/scsi/sd.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 624692c..3061acf 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -1701,14 +1701,15 @@ static int sd_done(struct scsi_cmnd *SCpnt)
                        sense_deferred = scsi_sense_is_deferred(&sshdr);
        }
 #ifdef CONFIG_SCSI_LOGGING
-       SCSI_LOG_HLCOMPLETE(1, scsi_print_result(SCpnt, SUCCESS));
+       SCSI_LOG_HLCOMPLETE(1, scmd_printk(KERN_INFO, SCpnt,
+               "sd_done: result[status,msg,host,driver]=%x,%x,%x,%x\n",
+               status_byte(result), msg_byte(result),
+               host_byte(result), driver_byte(result)));
        if (sense_valid) {
                SCSI_LOG_HLCOMPLETE(1, scmd_printk(KERN_INFO, SCpnt,
-                                                  "sd_done: sb[respc,sk,asc,"
-                                                  "ascq]=%x,%x,%x,%x\n",
-                                                  sshdr.response_code,
-                                                  sshdr.sense_key, sshdr.asc,
-                                                  sshdr.ascq));
+                       "sd_done: sb[respc,sk,asc,ascq]=%x,%x,%x,%x\n",
+                       sshdr.response_code, sshdr.sense_key,
+                       sshdr.asc, sshdr.ascq));
        }
 #endif
        sdkp->medium_access_timed_out = 0;
-- 
1.8.5.2

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to