Re: [PATCH v2] kref: warn on uninitialized kref

[Peter Zijlstra]

On Sat, May 17, 2014 at 05:14:13PM -0400, Mikulas Patocka wrote:
> BTW. if we talk about performance - what about replacing:
> 
>       if (atomic_dec_and_test(&variable)) {
>               ... release(object);
>       }
> 
> with this:
> 
>       if (atomic_read(&variable) == 1 || atomic_dec_and_test(&variable)) {
>               barrier();
>               ... release(object);
>       }

That would completely wreck kref_get_unless_zero().

pgpVP1oQ2uYC6.pgp
Description: PGP signature