On Tue, 2014-04-15 at 14:13 -0700, Andy Grover wrote: > Userspace tools assume if a value is read from configfs, it is valid > and will not cause an error if the same value is written back. The only > valid value for pi_prot_type for backends not supporting DIF is 0, so allow > this particular value to be set without returning an error. > > Reported-by: Krzysztof Chojnowski <[email protected]> > Signed-off-by: Andy Grover <[email protected]> > --- > drivers/target/target_core_device.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/target/target_core_device.c > b/drivers/target/target_core_device.c > index 65001e1..382b66b 100644 > --- a/drivers/target/target_core_device.c > +++ b/drivers/target/target_core_device.c > @@ -936,6 +936,10 @@ int se_dev_set_pi_prot_type(struct se_device *dev, int > flag) > return 0; > } > if (!dev->transport->init_prot || !dev->transport->free_prot) { > + /* 0 is only allowed value for non-supporting backends */ > + if (flag == 0) > + return 0; > + > pr_err("DIF protection not supported by backend: %s\n", > dev->transport->name); > return -ENOSYS;
Applied to target-pending/queue, and will merge into master as soon as the rebase to v3.15-rc occurs. Thanks! --nab -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
