Hi Quinn & Co, On Mon, 2014-03-31 at 16:15 +0000, Quinn Tran wrote: > On 3/28/14 5:22 PM, "sagi grimberg" <[email protected]> wrote: > > >On 3/29/2014 2:05 AM, Quinn Tran wrote: > >> Ram disk is allocating 8x more space than required for diff data. > >> For large RAM disk test, there is small potential for memory > >> starvation. > >> > >> Signed-off-by: Nicholas Bellinger <[email protected]> > >> Signed-off-by: Giridhar Malavali <[email protected]> > >> --- > >> drivers/target/target_core_rd.c | 6 +++++- > >> 1 file changed, 5 insertions(+), 1 deletion(-) > >> > >> diff --git a/drivers/target/target_core_rd.c > >>b/drivers/target/target_core_rd.c > >> index 01dda0b..6df177a 100644 > >> --- a/drivers/target/target_core_rd.c > >> +++ b/drivers/target/target_core_rd.c > >> @@ -253,7 +253,11 @@ static int rd_build_prot_space(struct rd_dev > >>*rd_dev, int prot_length) > >> if (rd_dev->rd_flags & RDF_NULLIO) > >> return 0; > >> > >> - total_sg_needed = rd_dev->rd_page_count / prot_length; > >> + /* prot_length=8byte dif data > >> + * tot sg needed = rd_page_count * (PGSZ/512) * (prot_length/PGSZ) + > >>pad > >> + * PGSZ canceled each other. > >> + */ > >> + total_sg_needed = (rd_dev->rd_page_count * prot_length / 512) +1; > > > >You probably will want to use block_size instead of hard-coding 512. > >Other then that this makes sense. > > QT> agreed >
Applying the following updated patch to target-pending/for-next, along with Sagi's comment wrt to block_size. Also adding your missing Signed-off-by. Please make sure to include these in future patches. ;) Thanks! --nab commit 435b88ba4a38adc39842957610b27a8d0fb4584b Author: Quinn Tran <[email protected]> Date: Fri Mar 28 19:05:27 2014 -0400 target/rd: T10-Dif: RAM disk is allocating more space than required. Ram disk is allocating 8x more space than required for diff data. For large RAM disk test, there is small potential for memory starvation. (Use block_size when calculating total_sg_needed - sagi + nab) Signed-off-by: Giridhar Malavali <[email protected]> Signed-off-by: Quinn Tran <[email protected]> Cc: <[email protected]> #3.14+ Signed-off-by: Nicholas Bellinger <[email protected]> diff --git a/drivers/target/target_core_rd.c b/drivers/target/target_core_rd.c index 66a5aba..b920db3 100644 --- a/drivers/target/target_core_rd.c +++ b/drivers/target/target_core_rd.c @@ -242,7 +242,7 @@ static void rd_release_prot_space(struct rd_dev *rd_dev) rd_dev->sg_prot_count = 0; } -static int rd_build_prot_space(struct rd_dev *rd_dev, int prot_length) +static int rd_build_prot_space(struct rd_dev *rd_dev, int prot_length, int block_size) { struct rd_dev_sg_table *sg_table; u32 total_sg_needed, sg_tables; @@ -252,8 +252,13 @@ static int rd_build_prot_space(struct rd_dev *rd_dev, int prot_length) if (rd_dev->rd_flags & RDF_NULLIO) return 0; - - total_sg_needed = rd_dev->rd_page_count / prot_length; + /* + * prot_length=8byte dif data + * tot sg needed = rd_page_count * (PGSZ/block_size) * + * (prot_length/block_size) + pad + * PGSZ canceled each other. + */ + total_sg_needed = (rd_dev->rd_page_count * prot_length / block_size) + 1; sg_tables = (total_sg_needed / max_sg_per_table) + 1; @@ -606,7 +611,8 @@ static int rd_init_prot(struct se_device *dev) if (!dev->dev_attrib.pi_prot_type) return 0; - return rd_build_prot_space(rd_dev, dev->prot_length); + return rd_build_prot_space(rd_dev, dev->prot_length, + dev->dev_attrib.block_size); } static void rd_free_prot(struct se_device *dev) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
