On 02/24/2014 09:07 PM, vikas.chaudh...@qlogic.com wrote: > From: Vikas Chaudhary <vikas.chaudh...@qlogic.com> > > Use correct goto statement to free dma memory in case of > failure in function qla4_84xx_config_acb() > > Signed-off-by: Vikas Chaudhary <vikas.chaudh...@qlogic.com> > --- > drivers/scsi/qla4xxx/ql4_mbx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/qla4xxx/ql4_mbx.c b/drivers/scsi/qla4xxx/ql4_mbx.c > index 0a6b782..1345c0e 100644 > --- a/drivers/scsi/qla4xxx/ql4_mbx.c > +++ b/drivers/scsi/qla4xxx/ql4_mbx.c > @@ -2381,7 +2381,7 @@ int qla4_84xx_config_acb(struct scsi_qla_host *ha, int > acb_config) > ql4_printk(KERN_ERR, ha, "%s: Unable to alloc acb\n", > __func__); > rval = QLA_ERROR; > - goto exit_config_acb; > + goto exit_free_acb; > } > memcpy(ha->saved_acb, acb, acb_len); > break; >
This patch looks ok, but is it possible to still leak the ha->saved_acb still? If you were going to do ACB_CONFIG_SET but the dma_alloc_coherent failed then it would not be freed. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
