On Sat, 2014-03-08 at 12:51 -0800, Arvind Kumar wrote: > This change ensures that pvscsi_abort() function returns SUCCESS > only when the command in question was actually completed, otherwise > returns FAILURE. The code before change, was causing a bug where > driver tries to complete a command to the mid-layer while the mid-layer > has already requested the driver to abort that command, in response > to which the driver has responded with SUCCESS causing mid-layer > to free the command struct. > > Signed-off-by: Arvind Kumar <arvindku...@vmware.com> > Cc: Ewan Milne <emi...@redhat.com>
This patch was verified by an OEM to fix a crash involving a double completion. The vmw_pvscsi driver was completing an scmd after having previously returned SUCCESS status on the scmd from .eh_abort_handler(). Acked-by: Ewan D. Milne <emi...@redhat.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
