> Is there extra scsi_mq_done() part that does IPI here even necessary > anymore..? > > I was under the assumption that blk_mq_end_io() is already taking care > of this..?
blk_mq_end_io does it, but given that the SCSI-specific I/O completion path is non-trivial I'd rather run it on the indicated CPU as well, similar to how the old blk-softirq code works. I'll send out a patch series that should make this area a lot cleaner and avoid having to implement the IPIs in each driver that wants or needs it soon. > OK, so your in-lining the allocation of data + protection SGLs from > blk-mq.. > > The original prototype code was doing these allocations separately below > for each pre-allocated cmd, and offering LLD's to optionally > pre-allocate their own descripts using sh->hostt->cmd_size if > necessary.. > > This was necessary to eliminate all fast-path allocations for > virtio-scsi, and I'd like to see something similar here as an optional > feature as well. It's present. The cmd_size host_template parameter is added in the previous series, and we still take it into account. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
