Fixed incorrect allocation of iDiags directories/files in debugfs

Signed-off-by: James Smart <james.sm...@emulex.com>

 ---

 lpfc_debugfs.c |   10 ++++++++++
 1 file changed, 10 insertions(+)


diff -upNr a/drivers/scsi/lpfc/lpfc_debugfs.c b/drivers/scsi/lpfc/lpfc_debugfs.c
--- a/drivers/scsi/lpfc/lpfc_debugfs.c  2013-11-26 21:45:44.000000000 -0500
+++ b/drivers/scsi/lpfc/lpfc_debugfs.c  2013-12-02 11:52:17.571242177 -0500
@@ -3927,6 +3927,7 @@ lpfc_debugfs_initialize(struct lpfc_vpor
        struct lpfc_hba   *phba = vport->phba;
        char name[64];
        uint32_t num, i;
+       bool pport_setup = false;
 
        if (!lpfc_debugfs_enable)
                return;
@@ -3947,6 +3948,7 @@ lpfc_debugfs_initialize(struct lpfc_vpor
        /* Setup funcX directory for specific HBA PCI function */
        snprintf(name, sizeof(name), "fn%d", phba->brd_no);
        if (!phba->hba_debugfs_root) {
+               pport_setup = true;
                phba->hba_debugfs_root =
                        debugfs_create_dir(name, lpfc_debugfs_root);
                if (!phba->hba_debugfs_root) {
@@ -4239,6 +4241,14 @@ lpfc_debugfs_initialize(struct lpfc_vpor
        }
 
        /*
+        * The following section is for additional directories/files for the
+        * physical port.
+        */
+
+       if (!pport_setup)
+               goto debug_failed;
+
+       /*
         * iDiag debugfs root entry points for SLI4 device only
         */
        if (phba->sli_rev < LPFC_SLI_REV4)


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to