Hello,

On Fri, Jan 11, 2013 at 11:16:26AM +0800, Aaron Lu wrote:
> OK, will make it atomic in next version, thanks for the advice.
> 
> Perhaps I can add two scsi helper functions in scsi_lib.c like:
> 
> void sdev_disable_disk_events(struct scsi_device *sdev)
> {
>       atomic_inc(&sdev->disk_events_disable_depth);
> }
> 
> void sdev_enable_disk_events(struct scsi_device *sdev)
> {
>       if (WARN_ON_ONCE(atomic_read(&sdev->disk_events_disable_depth) <= 0))
>               return;
>       atomic_dec(&sdev->disk_events_disable_depth);
> }
> 
> And call them in ATA layer. Do you like this?

Sounds good to me.  James, how does the series look to you?

Thanks!

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to