Bjorn, We will fix this bug in both mpt2sas and mpt3sas. Please note that we currently periodically release new features and defect fixes for both mpt2sas and mpt3sas. Most of these are then posted to upstream. We have a very well defined LSI internal process for synchronizing the defect fixes across the 2 drivers. A deliberate choice was made to keep the mpt3sas separate from mpt2sas due to our 6 GIG product being truly mature with a noticeable ramping down of enhancements/releases.
mpt3sas is at it's initial baseline with a healthy roadmap ahead. Architecturally there will be changes to the headers that will be only mpt3sas specific. From a maintenance and test perspective having the source base separate actually reduces the so called maintenance "hell". This is not a “mess” . LSI is fully capable of managing this software. Regards, Nagalakshmi -----Original Message----- From: Bjørn Mork [mailto:bj...@mork.no] Sent: Monday, December 17, 2012 6:55 PM To: Reddy, Sreekanth Cc: linux-scsi@vger.kernel.org; j...@kernel.org; yongjun_...@trendmicro.com.cn; weiyj...@gmail.com; Nandigama, Nagalakshmi Subject: Re: [PATCH -next] [SCSI] mpt3sas: remove unused variables <sreekanth.re...@lsi.com> writes: > diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c > b/drivers/scsi/mpt3sas/mpt3sas_scsih.c > index ac9dbc2..61a1a45 100644 > --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c > +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c > @@ -2754,13 +2754,11 @@ _scsih_block_io_to_children_attached_directly(struct > MPT3SAS_ADAPTER *ioc, > int i; > u16 handle; > u16 reason_code; > - u8 phy_number; > > for (i = 0; i < event_data->NumEntries; i++) { > handle = le16_to_cpu(event_data->PHY[i].AttachedDevHandle); > if (!handle) > continue; > - phy_number = event_data->StartPhyNum + i; > reason_code = event_data->PHY[i].PhyStatus & > MPI2_EVENT_SAS_TOPO_RC_MASK; > if (reason_code == MPI2_EVENT_SAS_TOPO_RC_DELAY_NOT_RESPONDING) There is an identical copy of this code, including that bug, in drivers/scsi/mpt2sas/mpt2sas_scsih.c. If you insist on the stupid code duplication, then please try to keep your bugs syncronized! If you are going to fix this bug for the mpt3sas driver, then you *have* to fix it for mpt2sas as well. Yes, I believe this is a mess and you have already demonstrated that you are incapable of managing it. Bjørn
