On 06/12/12 04:24, Chen Gang wrote: > Hello Maintainers: > > in drivers/target/sbp/sbp_target.c: > > tport->tpg must be NULL before process it in function sbp_make_tpg. (line > 2185..2188) > tport->tpg assigned a ptr (line 2198) > if processing failed, not set tport->tpg = NULL (line 2208..2212, > 2217..2221) > > we have done: when free tport->tpg, set it to NULL (line 2233..2234) > > is it valuable to let tport->tpg = NULL, when clean up for failure ? > <snip>
Yes, that's a good catch. The way it is now, if we fail to set up the TPG, the port will be left in an inconsistent state. I'll prepare a patch ASAP unless you'd rather do it yourself. Thanks, Chris -- Chris Boot bo...@bootc.net -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
