Hi Dan, On Tue, 2012-11-27 at 17:27 +0300, Dan Carpenter wrote: > We recently changed this to return positive subsystem error codes so the > error handling needs to be updated. > > Signed-off-by: Dan Carpenter <[email protected]> >
A nice catch on this sense_reason_t return breakage that I managed to introduce within for-3.8 code. Applied to for-next. Thank you! --nab > diff --git a/drivers/target/target_core_sbc.c > b/drivers/target/target_core_sbc.c > index 943c689..4fd22cd 100644 > --- a/drivers/target/target_core_sbc.c > +++ b/drivers/target/target_core_sbc.c > @@ -439,7 +439,7 @@ sbc_parse_cdb(struct se_cmd *cmd, struct sbc_ops *ops) > cmd->t_task_lba = get_unaligned_be64(&cdb[12]); > > ret = sbc_setup_write_same(cmd, &cdb[10], ops); > - if (ret < 0) > + if (ret) > return ret; > break; > default: > @@ -512,7 +512,7 @@ sbc_parse_cdb(struct se_cmd *cmd, struct sbc_ops *ops) > cmd->t_task_lba = get_unaligned_be64(&cdb[2]); > > ret = sbc_setup_write_same(cmd, &cdb[1], ops); > - if (ret < 0) > + if (ret) > return ret; > break; > case WRITE_SAME: > @@ -530,7 +530,7 @@ sbc_parse_cdb(struct se_cmd *cmd, struct sbc_ops *ops) > * of byte 1 bit 3 UNMAP instead of original reserved field > */ > ret = sbc_setup_write_same(cmd, &cdb[1], ops); > - if (ret < 0) > + if (ret) > return ret; > break; > case VERIFY: > -- > To unsubscribe from this list: send the line "unsubscribe target-devel" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
