Hi Wei,

On Fri, 2012-11-23 at 12:07 +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_...@trendmicro.com.cn>
> 
> The function iscsit_build_conn_drop_async_message() is called
> from iscsit_close_connection() with spin lock 'sess->conn_lock'
> held, so we should use GFP_ATOMIC instead of GFP_KERNEL.
> 
> Signed-off-by: Wei Yongjun <yongjun_...@trendmicro.com.cn>
> ---

Nice catch here.  Applied to target-pending/for-next, and including a CC
to stable.

Thank you!

--nab

>  drivers/target/iscsi/iscsi_target.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/target/iscsi/iscsi_target.c 
> b/drivers/target/iscsi/iscsi_target.c
> index 035c2c7..3983ad3 100644
> --- a/drivers/target/iscsi/iscsi_target.c
> +++ b/drivers/target/iscsi/iscsi_target.c
> @@ -2360,7 +2360,7 @@ static void iscsit_build_conn_drop_async_message(struct 
> iscsi_conn *conn)
>       if (!conn_p)
>               return;
>  
> -     cmd = iscsit_allocate_cmd(conn_p, GFP_KERNEL);
> +     cmd = iscsit_allocate_cmd(conn_p, GFP_ATOMIC);
>       if (!cmd) {
>               iscsit_dec_conn_usage_count(conn_p);
>               return;
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe target-devel" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to