On Thu, 19 Jul 2007 18:57:50 +0300 Boaz Harrosh wrote:
> Randy Dunlap wrote:
> >
> > Yes, this problem has been around forever AFAIK. You didn't add
> > to it.
> Do we need to file a bug report in Bugzilla or something, so people have a
> documentation of the work-around, until it is fixed?
Wouldn't hurt, I guess, but the SCSI people know about it.
> I think that for now I will wrap it up as it is. Could you send me the right
> BUG_ON() in place, with a printk pointing users to a solution? and I'll
> redo all the patches.
I didn't add a BUG_ON(), so I don't have that patch.
(I just used a .slave_alloc function to force no high memory data
addresses, just like ppa.c does.)
You could just do a BUG_ON() just before there is an outsw()
or insw() to a NULL pointer, e.g., in datao_run:
BUG_ON(CURRENT_SC->SCp.ptr);
or we could make building the driver depend on !HIGHMEM.
I prefer either of the !HIGHMEM or slave_alloc changes to adding
a BUG_ON(). However, the SCSI people likely won't want to use the
slave_alloc() change because then the driver may never get fixed.
(Of course, it hasn't got fixed with the BUG happening either.)
Anyway, I'll re-read Documentation/DMA*.txt to see if I can fix it.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
