On Wed, 6 Jun 2007 10:56:52 +0800 nickcheng(鄭守謙) wrote:
> Subject: [PATCH] scsi: improve areca driver stability and compatibility
>
> Description:
> 1. Implement PCI-Express error recovery function and AER capability
> 2. Implement the selection of ARCMSR_MAX_XFER_SECTORS_B=4096 if firmware
> version is latter than 1.42
> 3. Add arcmsr_done4_abort_postqueue in arcmsr_iop_reset function to
> improve the stability as hot-unplug/plug
> 4. Modify the ISR, arcmsr_interrupt routine, to prevent the inconsistency
> with sg_mod driver if application directly calls the arcmsr driver w/o
> passing through scsi midlayer specially thanks to Yanmin Zhang's openhanded
> help about AER
Hi,
1. See my sig line (i.e., the file Documentation/SubmitChecklist and
the script scripts/checkpatch.pl, which flags 298 _possible_ problems
with the patch).
2. Don't add trailing whitespace (spaces or tabs) (91 new patch lines
do this).
3. In arcmsr_build_ccb(), there is a new BUG_ON(). Is this absolutely
necessary? Is there any way to return an error at this point instead
of killing the entire system?
4. Use a space after 'if', 'while', and 'for'.
5. Use tabs to indent, not (8) spaces.
6. Some of the switch blocks (especially the default: one in
arcmsr_pci_ers_need_reset_forepart()) have very bad indentation style
and hence are very unreadable.
7. + int i=0,found=0;
kernel style is:
int i = 0, found = 0;
or:
int i = 0;
int found = 0;
8. + uint32_t flag_ccb,outbound_intstatus;
Need space after comma.
9. + while(((flag_ccb=readl(®->outbound_queueport)) != 0xFFFFFFFF) &&
Need space around = sign.
10. Try to limit source lines to no more than 80 characters.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
