On Mon, 07 May 2007 14:50:19 -0500
James Bottomley <[EMAIL PROTECTED]> wrote:

> On Thu, 2007-04-26 at 00:35 -0700, [EMAIL PROTECTED] wrote:
> > From: Richard Knutsson <[EMAIL PROTECTED]>
> > 
> > Convert:
> > FALSE -> false
> > TRUE  -> true
> 
> NAK'd by maintainer.
> 

I went back and reviewed the previous discussion.  Maintaner's reasons for
NAKing were, and remain wholly specious.

That being said, the patch is moderately wrong (or at least incomplete)
because it does things like:

-            unsigned char done = FALSE;
+            unsigned char done = false;

whereas it should have done

-            unsigned char done = FALSE;
+            bool done = false;

so I'll drop it on those grounds, not on the bogus ones.
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to