Found the problem.  Sending a patch to linux-scsi under a [PATCH]
subject line.

- Doug

On Fri, 2007-05-04 at 17:58 -0500, James Bottomley wrote:
> On Fri, 2007-05-04 at 17:56 -0400, Doug Chapman wrote:
> > I am applying/removing _only_ your patch and the problem goes away with
> > just removing it.
> 
> What id and channel is this DVD drive on?  There is a potential bug in
> the move:
> 
> -mptscsih_writeIOCPage4(MPT_SCSI_HOST *hd, int channel, int id)
> +mptspi_writeIOCPage4(MPT_SCSI_HOST *hd, u8 channel , u8 id)
> 
> Note int became u8, but later we have:
> 
> 
>       pReq->PageAddress = cpu_to_le32(id | (channel << 8 ));
> 
> channel << 8 is always zero as a u8 entity (unless something promotes
> the arithmetic beyond u8).  So if the DVD is on a non-zero channel, we
> might have our cause.
> 
> James
> 
> 

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to