David C Somayajulu wrote: > The following set of patches > 1. add support for ipv6 for qla4032 > 2. provide bug fixes > 3. misc. support > > Patch 1/5 > has changes to the driver and firmware related structures to > 1. clean up and make the firmware related structures look linux like. > 2. add fields/structures for ipv6 support > 3. add support for capaturing all AEN types in a ring buffer, to aid > troubleshooting. > 4. abstract the functions for sending commands to the HBA (i.e., > sending via Request Queue or Mailbox registers) so that the underlying > functions can be different in future hardware. Also mailbox commands which > are not performance critical may be sent via Request Queues (using mailbox > iocbs). > > Patch 2/5 > has the following changes for initialization routines. > 1. fix qla4x00_pci_config() > 2. fix in qla4xxx_add_device_dynamically(), so that a new target > coming online and existing targets which went offline and then came back > online are differentiated. > 3. In qla4xxx_build_ddb_list() the firmware ddb entry's state needs > to be updated by calling qla4xxx_get_fwddb_entry() after > qla4xxx_set_ddb_entry(). [...]
I have no technical comments, just a formal one: Even though you perhaps don't expect the patches to be committed as-is, you should give each patch an own descriptive patch title (instead of naming them all "qla4xxx: Add IPv6 support and misc"). Also, you could put the above descriptions into the individual patch descriptions. -- Stefan Richter -=====-=-=== -=-= ---== http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
