> +                     u32 temp = le32_to_cpu(psg->sg[i-1].count) - 
> +                             (byte_count - scsicmd->request_bufflen);
> +                     psg->sg[i-1].count = cpu_to_le32(temp);

You really want {be,le}*_{add,sub} helpers.  I needed them on various
occasions, too.  Al, what do you think about adding these helpers to a
common header somewhere?

> +#define LE32_ALL_ONES ((__force __le32)0xffffffff)

I don't like having this in an actual driver.  It might make sense to
either have this in a common header or actually allowing to assign all
ones to __l32*/__be* variables.  Al?

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to