On Wed, Mar 30, 2005 at 05:15:55AM +0200, Kay Sievers wrote: > --- > sysfs: allow change of permissions for already created attributes > > Signed-off-by: Kay Sievers <[EMAIL PROTECTED]> > > ===== fs/sysfs/file.c 1.23 vs edited ===== > --- 1.23/fs/sysfs/file.c 2005-02-26 15:48:19 +01:00 > +++ edited/fs/sysfs/file.c 2005-03-30 04:16:46 +02:00 > @@ -428,6 +428,39 @@ int sysfs_update_file(struct kobject * k > > > /** > + * sysfs_chmod_file - update the modified mode value on an object attribute. > + * @kobj: object we're acting for. > + * @mode: file permissions. > + * > + */ > +int sysfs_chmod_file(struct kobject *kobj, const struct attribute *attr)
Your documentation doesn't match up with your function arguments :) Shouldn't you want an extra mode variable? Makes it easier to override than remembering to change the mode in the attribute before calling the function. thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
