On 03/06/2005 05:27:41 PM, [EMAIL PROTECTED] wrote:
> 
> 
> Use msleep() instead of schedule_timeout() to guarantee the task
> delays as expected. Although TASK_INTERRUPTIBLE is used in the current code,
> there is no code dealing with an early return / signals_pending().

This change is a total don't-care as far as I'm concerned. But if we are going 
to 
make it, can we please be consistent? Does the 
"set_current_state(TASK_INTERRUPTIBLE)"
stay or go? The two changes below don't agree in that respect.

---
>                       attempts--;
> -                     set_current_state(TASK_INTERRUPTIBLE);
> -                     schedule_timeout(HZ / 10);
> +                     msleep(100);
>               }
---
>  #endif
>               set_current_state(TASK_INTERRUPTIBLE);
> -             schedule_timeout(HZ / 10);
> +             msleep(100);
>       }
---

Regards, Willem Riede,
osst maintainer.

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to