Cool! A good catch that could only be caught with many eyes looking at the code.
Wasn't in my branch though, but it looks like a common typo ;-/. But the sad part of this is that I use casts around voids to improve type checking (and enforce/document intentions) and it now appears to be a waste. I assume you did not see a warning message from your compile environment, right? Sincerely -- Mark Salyzyn -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Al Viro Sent: Wednesday, February 02, 2005 2:14 PM To: Linus Torvalds Cc: [email protected] Subject: [PATCH] (7/27) *really* dumb typo in aacraid (cast to pointer to structure that doesn't exist ;-) spot the typo... It's harmless, in a sense that code compiles right, but... Signed-off-by: Al Viro <[EMAIL PROTECTED]> ---- diff -urN RC11-rc2-bk10-rme9652/drivers/scsi/aacraid/aachba.c RC11-rc2-bk10-aacraid/drivers/scsi/aacraid/aachba.c --- RC11-rc2-bk10-rme9652/drivers/scsi/aacraid/aachba.c Tue Feb 1 21:44:42 2005 +++ RC11-rc2-bk10-aacraid/drivers/scsi/aacraid/aachba.c Wed Feb 2 08:12:13 2005 @@ -1047,7 +1047,7 @@ COMMAND_COMPLETE << 8 | SAM_STAT_GOOD; else { struct scsi_device *sdev = cmd->device; - struct aac_dev *dev = (struct aav_dev *)sdev->host->hostdata; + struct aac_dev *dev = (struct aac_dev *)sdev->host->hostdata; u32 cid = ID_LUN_TO_CONTAINER(sdev->id, sdev->lun); printk(KERN_WARNING "synchronize_callback: synchronize failed, status = %d\n", - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
