On Tuesday, January 18, 2005 4:22 AM, Andi Kleen wrote: > > Convert mptctl driver to new compat_ioctl entry point. > > Only compile tested. > > Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> >
This doesn't compile. Andi - Pls fix, resend, and I will test. Three issues are: (1) incompatible number of paramters being passed when calling __mptctl_ioctl; look at line 649 (2) definition of unlocked_ioctl is three parameters, however mptctl_ioctl is having four paramters; line 2686 (3) compat_mptctl_ioctl - is passing NULL pointer to mptctl_ioctl, this will panic in __mptctl_ioctl; look at line 2820, then line 566 Here is output of compiling: emoore-test5:/usr/src/linux-2.6.11-rc1-bk7 # make modules CHK include/linux/version.h make[1]: `arch/x86_64/kernel/asm-offsets.s' is up to date. CC [M] drivers/message/fusion/mptctl.o drivers/message/fusion/mptctl.c: In function `mptctl_ioctl': drivers/message/fusion/mptctl.c:649: warning: passing arg 1 of `__mptctl_ioctl' from incompatible pointer type drivers/message/fusion/mptctl.c:649: warning: passing arg 2 of `__mptctl_ioctl' makes integer from pointer without a cast drivers/message/fusion/mptctl.c:649: error: too many arguments to function `__mptctl_ioctl' drivers/message/fusion/mptctl.c: At top level: drivers/message/fusion/mptctl.c:2686: warning: initialization from incompatible pointer type make[3]: *** [drivers/message/fusion/mptctl.o] Error 1 make[2]: *** [drivers/message/fusion] Error 2 make[1]: *** [drivers/message] Error 2 - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
