On Fri, 2010-01-29 at 23:01 +0000, Matthew W. S. Bell wrote:
> When a failure occurs loading a dependee module, an error for this is
> not printed, but an incorrect error is printed for each dependent
> module. This patch changes this.
I see what you're trying to solve here, but the existing code has to
handle the case of loading multiple modules by means of dependencies
*and* in the case that -a is specified on the command line. I am
thinking the following:
- if ((error != warn) || (verbose))
+ if (!all || verbose)
error("Error inserting %s (%s): %s\n",
mod->modname, mod->filename,
insert_moderror(errno));
Needs to be:
if ((!all && (error != warn)) || (verbose))
Jon.
--
To unsubscribe from this list: send the line "unsubscribe linux-modules" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
