On Tue, Aug 25, 2015 at 12:36 AM, Hans Verkuil <hverk...@xs4all.nl> wrote: > On 08/23/2015 10:17 PM, Mauro Carvalho Chehab wrote: >> From: Javier Martinez Canillas <jav...@osg.samsung.com> >> >> The struct media_entity has a .parent field that stores a pointer >> to the parent struct media_device. But recently a media_gobj was >> embedded into the entities and since struct media_gojb already has >> a pointer to a struct media_device in the .mdev field, the .parent >> field becomes redundant and can be removed. >> >> This patch replaces all the usage of .parent by .graph_obj.mdev so >> that field will become unused and can be removed on a later patch. >> >> No functional changes. >> >> The transformation was made using the following coccinelle spatch: >> >> @@ >> struct media_entity *me; >> @@ >> >> - me->parent >> + me->graph_obj.mdev >> >> @@ >> struct media_entity *link; >> @@ >> >> - link->source->entity->parent >> + link->source->entity->graph_obj.mdev >> >> @@ >> struct exynos_video_entity *ve; >> @@ >> >> - ve->vdev.entity.parent >> + ve->vdev.entity.graph_obj.mdev >> >> Suggested-by: Mauro Carvalho Chehab <mche...@osg.samsung.com> >> >> Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> >> Signed-off-by: Mauro Carvalho Chehab <mche...@osg.samsung.com> > > Acked-by: Hans Verkuil <hans.verk...@cisco.com>
The change looks good to me. I would really like to see a before and after media graph with these changes, this patch and series in general. thanks, -- Shuah -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
