Hi Sakari,

Thank you for the review.

On Thursday 06 February 2014 19:33:23 Sakari Ailus wrote:
> Hi Laurent,
> 
> On Wed, Feb 05, 2014 at 05:41:57PM +0100, Laurent Pinchart wrote:
> > Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> > ---
> > 
> >  include/media/v4l2-subdev.h    | 4 ++++
> >  include/uapi/linux/videodev2.h | 8 ++++++--
> >  2 files changed, 10 insertions(+), 2 deletions(-)
> > 
> > diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
> > index d67210a..2c7355a 100644
> > --- a/include/media/v4l2-subdev.h
> > +++ b/include/media/v4l2-subdev.h
> > @@ -505,6 +505,10 @@ struct v4l2_subdev_pad_ops {
> > 
> >                          struct v4l2_subdev_selection *sel);
> >     
> >     int (*get_edid)(struct v4l2_subdev *sd, struct v4l2_subdev_edid 
*edid);
> >     int (*set_edid)(struct v4l2_subdev *sd, struct v4l2_subdev_edid 
*edid);
> > 
> > +   int (*dv_timings_cap)(struct v4l2_subdev *sd,
> > +                         struct v4l2_dv_timings_cap *cap);
> > +   int (*enum_dv_timings)(struct v4l2_subdev *sd,
> > +                          struct v4l2_enum_dv_timings *timings);
> 
> Do you think there would be use for these in the user space API? The
> argument structs are defined in the user space header. The driver does also
> export a sub-device node.

Please have a look at

[PATCH 27/47] v4l: Add support for DV timings ioctls on subdev nodes

:-)

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to