Hi Hans,

On Mon, Jan 20, 2014 at 01:45:58PM +0100, Hans Verkuil wrote:
> +     union {
> +             __u64 val;
> +             __u32 reserved[4];
> +     } step;

While I do not question that step is obviously always a positive value (or
zero), using a different type from the value (and min and max) does add
slight complications every time it is being used. I don't think there's a
use case for using values over 2^62 for step either.

Speaking of which --- do you think we should continue to have step in the
interface? This has been proven to be slightly painful when the step is not
an integer. Using a step of one in that case has been the only feasible
solution. Step could be naturally be used as a hint but enforcing it often
forces setting it to one.

-- 
Kind regards,

Sakari Ailus
e-mail: sakari.ai...@iki.fi     XMPP: sai...@retiisi.org.uk
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to