Hi Kamil,
On 12/11/13 11:27, Kamil Debski wrote:
> Hi,
>
>> From: Hans Verkuil [mailto:hverk...@xs4all.nl]
>> Sent: Tuesday, December 10, 2013 8:52 AM
>>
>> As Guennadi mentioned in his review, ENODATA will be replaced by
>> ENOBUFS, which is more appropriate.
>>
>> Prabhakar, Kamil, Tomasz, are you OK with this patch provided
>> s/ENODATA/ENOBUFS/ ?
>
> The patch looks good. However, shouldn't the documentation be changed too?
>
> Now it says: [1]
> "(...) Accordingly the output hardware is disabled, no video signal is
> produced until VIDIOC_STREAMON has been called. The ioctl will succeed
> only when at least one output buffer is in the incoming queue. (...)"
>
> If I understand correctly, now the ioctl will succeed with no buffers
> queued.
That's true *only* for drivers using vb2. As long as not all drivers are
converted (which is a *very* long-term project) I don't think i can change
the documentation.
Regards,
Hans
> Apart from the above you have my ack.
>
> Acked-by: Kamil Debski <k.deb...@samsung.com>
>
> Best wishes,
>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
