On Sat, 2013-11-02 at 11:31 -0200, Mauro Carvalho Chehab wrote: > On cris and frv archs, the functions below aren't defined: > drivers/media/platform/sh_veu.c: In function 'sh_veu_reg_read': > drivers/media/platform/sh_veu.c:228:2: error: implicit declaration of > function 'ioread32' [-Werror=implicit-function-declaration] > drivers/media/platform/sh_veu.c: In function 'sh_veu_reg_write': > drivers/media/platform/sh_veu.c:234:2: error: implicit declaration of > function 'iowrite32' [-Werror=implicit-function-declaration] > drivers/media/platform/vsp1/vsp1.h: In function 'vsp1_read': > drivers/media/platform/vsp1/vsp1.h:66:2: error: implicit declaration of > function 'ioread32' [-Werror=implicit-function-declaration] > drivers/media/platform/vsp1/vsp1.h: In function 'vsp1_write': > drivers/media/platform/vsp1/vsp1.h:71:2: error: implicit declaration of > function 'iowrite32' [-Werror=implicit-function-declaration] > drivers/media/platform/vsp1/vsp1.h: In function 'vsp1_read': > drivers/media/platform/vsp1/vsp1.h:66:2: error: implicit declaration of > function 'ioread32' [-Werror=implicit-function-declaration] > drivers/media/platform/vsp1/vsp1.h: In function 'vsp1_write': > drivers/media/platform/vsp1/vsp1.h:71:2: error: implicit declaration of > function 'iowrite32' [-Werror=implicit-function-declaration] > drivers/media/platform/soc_camera/rcar_vin.c: In function > 'rcar_vin_setup': > drivers/media/platform/soc_camera/rcar_vin.c:284:3: error: implicit > declaration of function 'iowrite32' [-Werror=implicit-function-declaration] > drivers/media/platform/soc_camera/rcar_vin.c: In function > 'rcar_vin_request_capture_stop': > drivers/media/platform/soc_camera/rcar_vin.c:353:2: error: implicit > declaration of function 'ioread32' [-Werror=implicit-function-declaration] > > While this is not fixed, remove those 3 drivers from building on > those archs. [...]
Well where does this stop? There will be many other drivers that are broken if those functions are missing, and there's going to be a lot of churn if we disable them all and then reenable when the architecture headers are fixed. cris selects the generic implementations (CONFIG_GENERIC_IOMAP) but I think arch/cris/include/asm/io.h is missing #include <asm-generic/iomap.h>. frv defines these functions inline in arch/frv/include/asm/io.h so I don't know what the problem is there. Ben. -- Ben Hutchings Kids! Bringing about Armageddon can be dangerous. Do not attempt it in your own home. - Terry Pratchett and Neil Gaiman, `Good Omens'
signature.asc
Description: This is a digitally signed message part
