As reported by Jim Davis <jim.ep...@gmail.com>,
building with:
        CONFIG_USB=m
        CONFIG_SMS_USB_DRV=m
        CONFIG_SMS_SDIO_DRV=y
        CONFIG_SMS_SIANO_MDTV=y
        CONFIG_SMS_SIANO_DEBUGFS=y

causes a build error:

        drivers/built-in.o: In function `smsdvb_debugfs_register':
        /home/jim/linux/drivers/media/common/siano/smsdvb-debugfs.c:537:
        undefined reference to `usb_debug_root'
        make: *** [vmlinux] Error 1

That happens because the siano-mdtv is builtin, while USB is a
module. As it makes not much sense to have sms-usb compiled as 'm'
and sms-sdio compiled as 'y' (or vice-versa), only allow enabling
debugfs if both are either 'y' or 'm'.

Reported-by: Jim Davis <jim.ep...@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <m.che...@samsung.com>
---
 drivers/media/common/siano/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/media/common/siano/Kconfig 
b/drivers/media/common/siano/Kconfig
index f3f5ec4..f953d33 100644
--- a/drivers/media/common/siano/Kconfig
+++ b/drivers/media/common/siano/Kconfig
@@ -23,6 +23,8 @@ config SMS_SIANO_DEBUGFS
        depends on SMS_SIANO_MDTV
        depends on DEBUG_FS
        depends on SMS_USB_DRV
+       depends on CONFIG_SMS_USB_DRV = CONFIG_SMS_SDIO_DRV
+
        ---help---
          Choose Y to enable visualizing a dump of the frontend
          statistics response packets via debugfs. Currently, works
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to