On Sun, 16 Dec 2012 14:34:31 -0800 Albert Wang <twan...@marvell.com> wrote:
> >What is the purpose of the "usebufs" field? The code maintains it in > >various places, but I don't see anywhere that actually uses that value for > >anything. > > > [Albert Wang] Two buffers mode doesn't need it. > But Three buffers mode need it indicates which conditions we need set the > single buffer flag. > I used "tribufs" as the name in the previous version, but it looks it's a > confused name when we merged > Two buffers mode and Three buffers mode with same code by removing #ifdef > based on your comments months ago. :) > So we just changed the name with "usebufs". OK, I misread the code a bit, sorry. I do find the variable confusing still, but it clearly does play a role. I think that using three buffers by default would make sense. I don't think that increased overruns are an unbreakable ABI feature :) Feel free to add my ack to this one. Thanks, jon -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
