> -----Original Message-----
> From: Shubhrajyoti Datta [mailto:omaplinuxker...@gmail.com]
> Sent: Tuesday, September 18, 2012 3:30 PM
> To: Venu Byravarasu
> Cc: Shubhrajyoti D; linux-media@vger.kernel.org; linux-
> ker...@vger.kernel.org; julia.law...@lip6.fr
> Subject: Re: [PATCHv2 6/6] media: Convert struct i2c_msg initialization to C99
> format
> >> struct i2c_msg test[2] = {
> >> - { client->addr, 0, 3, write },
> >> - { client->addr, I2C_M_RD, 2, read },
> >> + {
> >> + .addr = client->addr,
> >> + .flags = 0,
> >
> > Does flags not contain 0 by default?
> >
>
> It does however I felt that 0 means write so letting it be explicit.
>
> In case a removal is preferred that's doable too however felt it is
> more readable this way.
Though it adds readability, it carries an overhead of one write operation too.
So, better to remove it.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
