On Mon 11 June 2012 10:12:11 Sakari Ailus wrote:
> On Mon, Jun 11, 2012 at 09:49:25AM +0200, Laurent Pinchart wrote:
> > Hi Sakari,
>
> Hi Laurent,
>
> > On Saturday 26 May 2012 23:07:49 Sakari Ailus wrote:
> > > The __user macro is not strictly needed in videodev2.h, and it also
> > > prevents
> > > using the header file as such in the user space. __user is already not
> > > used
> > > in many of the interface structs containing pointers.
> > >
> > > Stop using __user in videodev2.h.
> >
> > Please don't. __user is useful. You should not use kernel headers as-is in
> > userspace, they need to be installed use make headers_install first.
>
> Then we should consistently use it, and not just in these two occasions.
> Currently most structures having pointers and which are part of the user
> space interface don't have that. One example is v4l2_ext_controls.
Yes, that should be fixed. All pointers in structs whose contents is going
to be copied to/from kernelspace need a __user annotation.
The sparse checker checks for that. I'm running it in my daily build, but
nobody ever pays any attention to it :-)
There are too many error/warnings reported for it to be any use.
Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
