On Sat, Aug 13, 2011 at 9:43 PM, Chris Rankin <ranki...@yahoo.com> wrote:
> Hi,
>
> The rc-pinnacle-pctv-hd keymap is missing the definition of the OK key:
>
> --- linux-3.0/drivers/media/rc/keymaps/rc-pinnacle-pctv-hd.c.orig       
> 2011-08-14 02:42:01.000000000 +0100
> +++ linux-3.0/drivers/media/rc/keymaps/rc-pinnacle-pctv-hd.c    2011-08-14 
> 02:12:45.000000000 +0100
> @@ -20,6 +20,7 @@
>        { 0x0701, KEY_MENU }, /* Pinnacle logo */
>        { 0x0739, KEY_POWER },
>        { 0x0703, KEY_VOLUMEUP },
> +       { 0x0705, KEY_OK },
>        { 0x0709, KEY_VOLUMEDOWN },
>        { 0x0706, KEY_CHANNELUP },
>        { 0x070c, KEY_CHANNELDOWN },
>
> Cheers,
> Chris

Wow, how the hell did I miss that?  I did numerous remotes for em28xx
based devices that use that RC profile, and never noticed that issue.

Will have to check the merge logs.  Maybe the key got lost when they
refactored the IR support.

Chris, you should add a signed-off-by tag and submit this as a patch
so it can be included upstream.

Devin

-- 
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to