> -----Original Message----- > From: Hiremath, Vaibhav > Sent: Thursday, July 07, 2011 11:25 AM > To: David Rientjes; JAIN, AMBER > Cc: Mauro Carvalho Chehab; linux-media@vger.kernel.org; Andrew Morton > Subject: RE: [GIT PULL for v3.0] OMAP_VOUT bug fixes and code cleanup > > > -----Original Message----- > > From: David Rientjes [mailto:rient...@google.com] > > Sent: Thursday, July 07, 2011 2:14 AM > > To: JAIN, AMBER > > Cc: Mauro Carvalho Chehab; Hiremath, Vaibhav; linux- > me...@vger.kernel.org; > > Andrew Morton > > Subject: RE: [GIT PULL for v3.0] OMAP_VOUT bug fixes and code cleanup > > > > On Tue, 5 Jul 2011, JAIN, AMBER wrote: > > > > > > > diff --git a/drivers/media/video/omap24xxcam.c > > > > b/drivers/media/video/omap24xxcam.c > > > > > index f6626e8..d92d4c6 100644 > > > > > --- a/drivers/media/video/omap24xxcam.c > > > > > +++ b/drivers/media/video/omap24xxcam.c > > > > > @@ -309,11 +309,11 @@ static int > > > > omap24xxcam_vbq_alloc_mmap_buffer(struct videobuf_buffer *vb) > > > > > order--; > > > > > > > > > > /* try to allocate as many contiguous pages as possible > > */ > > > > > - page = alloc_pages(GFP_KERNEL | GFP_DMA, order); > > > > > + page = alloc_pages(GFP_KERNEL, order); > > > > > /* if allocation fails, try to allocate smaller amount > > */ > > > > > while (page == NULL) { > > > > > order--; > > > > > - page = alloc_pages(GFP_KERNEL | GFP_DMA, order); > > > > > + page = alloc_pages(GFP_KERNEL, order); > > > > > if (page == NULL && !order) { > > > > > err = -ENOMEM; > > > > > goto out; > > > > > > > > Hmm... the proper fix wouldn't be to define ZONE_DMA at OMAP? > > > > > > I don't think so, my understanding for ZOME_DMA is that it is defined > > > for architectures that have restrictions on memory addresses that can > be > > > used for DMA. OMAP doesn't have any such restriction and hence we > should > > > not define ZONE_DMA. > > > > > > > s/should not define/do not need to define/ > > > > Right, if omap does not have DMA restrictions then the GFP_DMA usage > that > > is removed with this patch was incorrect. > [Hiremath, Vaibhav] I did not understand your comment; can you please help > me to understand here?
I think what David wants to say is that if we do not have DMA restrictions on OMAP we should have not used GFP_DMA flag for page allocation at first place. Is my understanding correct David? ~Amber > > Thanks, > Vaibhav -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
