Em 30-06-2011 10:20, Mauro Carvalho Chehab escreveu:
> Em 30-06-2011 09:35, Mauro Carvalho Chehab escreveu:
>> Em 30-06-2011 07:55, Hans de Goede escreveu:
>
>>> 1) This bit should be #ifdef __linux__ since we only support
>>> auto* on linux because of the sysfs dep:
>>
>> True, but instead of adding it on every place, the better would be to
>> replace auto/auto_tv
>> at the library, instead of adding the test at each place we change to auto
>> mode.
>
> I fixed it using this approach.
>
>>> 2) The added return NULL in case no device can be found lacks
>>> printing an error message:
>
>>> I propose changing the return NULL, with a goto to the error print further
>>> down.
>>
>> Yes, that sounds better to me.
>
> The error message didn't look good, so I added an specific message for it.
>
> Yet, IMO, we're being too verbose:
>
> $ scantv
> vid-open-auto: failed to open an analog TV device at /dev/video0
> vid-open: could not find a suitable videodev
> no analog TV device available
Ah, calling it without any media driver is also verbose and wrong:
$ xawtv
This is xawtv-, running on Linux/x86_64 (2.6.32-131.0.15.el6.x86_64)
vid-open-auto: failed to open a capture device at
vid-open: could not find a suitable videodev
no video grabber device available
$ scantv
vid-open-auto: failed to open an analog TV device at �7
vid-open: could not find a suitable videodev
no analog TV device available
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
