On Saturday, February 05, 2011 15:29:47 Stefan Richter wrote:
> On Feb 05 Hans Verkuil wrote:
> > (Second attempt: fixes a link issue with firedtv and adds removal of the
> > old ioctls)
> >
> > This patch series removes the last V4L1 drivers (Yay!), the obsolete dabusb
> > driver,
> > the ieee1394-stack part of the firedtv driver (the IEEE1394 stack was
> > removed in
> > 2.6.37), and the VIDIOC_*_OLD ioctls.
> >
> > Stefan, I went ahead with this since after further research I discovered
> > that
> > this driver hasn't been compiled at all since 2.6.37! The Kconfig had a
> > dependency on IEEE1394, so when that config was removed, the driver no
> > longer
> > appeared in the config.
> >
> > I removed any remaining reference to IEEE1394 and changed the Kconfig
> > dependency
> > to FIREWIRE. At least it compiles again :-)
>
> Thanks for doing the firedtv cleanup. However, the effect should just be
> that of dead code elimination. Was there any build problem that I missed?
You missed something, but it turns out not to be a build problem as such on
closer inspection.
I got confused by this code in drivers/media/dvb/Kconfig:
comment "Supported FireWire (IEEE 1394) Adapters"
depends on DVB_CORE && IEEE1394
source "drivers/media/dvb/firewire/Kconfig"
Since the comment depends on IEEE1394 it disappeared once IEEE1394 was removed.
So when I looked for this comment in the menu is was no longer there. But the
actual driver still is, and I missed that.
So it was just the comment dependency that was wrong, not the driver itself.
Sorry for the confusion.
Regards,
Hans
> AFAICS, firedtv builds and works fine in mainline 2.6.37(-rc) and
> 2.6.38(-rc). From when I implemented the drivers/firewire/ backend of
> firedtv, it should have been possible to build firedtv for a kernel with
> one or both of drivers/{ieee1394,firewire}; controlled by whether
> CONFIG_{IEEE1394,FIREWIRE} are defined or not.
>
> I will have a look at your changes later.
>
--
Hans Verkuil - video4linux developer - sponsored by Cisco
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
