Hello.

Manjunath Hadli wrote:

This patch implements the overall device creation for the Video
display driver

Signed-off-by: Manjunath Hadli <manjunath.ha...@ti.com>
Acked-by: Muralidharan Karicheri <m-kariche...@ti.com>
Acked-by: Hans Verkuil <hverk...@xs4all.nl>
[...]

diff --git a/arch/arm/mach-davinci/dm644x.c b/arch/arm/mach-davinci/dm644x.c
index 9a2376b..eb87867 100644
--- a/arch/arm/mach-davinci/dm644x.c
+++ b/arch/arm/mach-davinci/dm644x.c
@@ -370,6 +370,7 @@ static struct platform_device dm644x_mdio_device = {
  *     soc     description     mux  mode   mode  mux    dbg
  *                             reg  offset mask  mode
  */
+

   Stray newline?

[...]
+static struct resource dm644x_venc_resources[] = {
+       /* venc registers io space */
+       {
+               .start  = 0x01C72400,
+               .end    = 0x01C72400 + 0x17f,
+               .flags  = IORESOURCE_MEM,
+       },
+};
+
[...]
+static struct resource dm644x_v4l2_disp_resources[] = {
+       {
+               .start  = IRQ_VENCINT,
+               .end    = IRQ_VENCINT,
+               .flags  = IORESOURCE_IRQ,
+       },
+       {
+               .start  = 0x01C724B8,
+               .end    = 0x01C724B8 + 0x3,
+               .flags  = IORESOURCE_MEM,
+       },
+};

   Still intersects with dm644x_venc_resources[]. Is it intended?

 static int __init dm644x_init_devices(void)
 {
        if (!cpu_is_davinci_dm644x())
                return 0;
- /* Add ccdc clock aliases */
-       clk_add_alias("master", dm644x_ccdc_dev.name, "vpss_master", NULL);
-       clk_add_alias("slave", dm644x_ccdc_dev.name, "vpss_slave", NULL);
        platform_device_register(&dm644x_edma_device);
-

   Should've left this newline alone...

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to