On Friday, November 19, 2010 16:55:43 Marek Szyprowski wrote:
> Make vivi use videobuf2 in place of videobuf.
> 
> Signed-off-by: Pawel Osciak <p.osc...@samsung.com>
> Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.p...@samsung.com>
> CC: Pawel Osciak <pa...@osciak.com>

<snip>

> -static void vivi_stop_generating(struct file *file)
> +static void vivi_stop_generating(struct vivi_dev *dev)
>  {
> -     struct vivi_dev *dev = video_drvdata(file);
>       struct vivi_dmaqueue *dma_q = &dev->vidq;
>  
>       dprintk(dev, 1, "%s\n", __func__);
>  
> -     if (!file->private_data)
> -             return;
> -     if (!test_and_clear_bit(0, &dev->generating))
> -             return;
> -
>       /* shutdown control thread */
>       if (dma_q->kthread) {
>               kthread_stop(dma_q->kthread);
>               dma_q->kthread = NULL;
>       }
> -     videobuf_stop(&dev->vb_vidq);
> -     videobuf_mmap_free(&dev->vb_vidq);
> -}
>  
> -static int vivi_is_generating(struct vivi_dev *dev)
> -{
> -     return test_bit(0, &dev->generating);
> +     /*
> +      * Typical driver might need to wait here until dma engine stops.
> +      * In this case we can abort imiedetly, so it's just a noop.

typo: imiedetly -> immediately

<snip>


Regards,

        Hans

-- 
Hans Verkuil - video4linux developer - sponsored by Cisco
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to