On Oct 20, 2010, at 1:18 PM, Mauro Carvalho Chehab wrote:

> The RC5 decoding is complete at a BIT_END state. there's no reason
> to wait for the next space to produce a code.

Well, if I'm reading things correctly here, I think the only true functional 
difference made to the decoder here was to skip the if (ev.pulse) break; check 
in STATE_FINISHED, no? In other words, this looks like it was purely an issue 
with the receiver data parsing, which was ending on a pulse instead of a space. 
I can make this guess in greater confidence having seen another patch somewhere 
that implements a different buffer parsing routine for the polaris devices 
though... ;)

The mceusb portion of the patch is probably a worthwhile micro-optimization of 
its ir processing routine though -- don't call ir_raw_event_handle if there's 
no event to handle. Lemme just go ahead and merge that part via my staging 
tree, if you don't mind. (I've got a dozen or so IR patches that have been 
queueing up, planning on another pull req relatively soon).

-- 
Jarod Wilson
ja...@wilsonet.com



--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to