Hi, Am Mittwoch, den 10.02.2010, 20:36 +0100 schrieb Jean Delvare: > On Wed, 10 Feb 2010 16:40:03 -0200, Mauro Carvalho Chehab wrote: > > Jean Delvare wrote: > > > Under the assumption that saa7134_hwinit1() only touches GPIOs > > > connected to IR receivers (and it certainly looks like this to me) I > > > fail to see how these pins not being initialized could have any effect > > > on non-IR code. > > > > Now, i suspect that you're messing things again: are you referring to > > saa7134_hwinit1() or > > to saa7134_input_init1()? > > > > I suspect that you're talking about moving saa7134_input_init1(), since > > saa7134_hwinit1() > > has the muted and spinlock inits. It also has the setups for video, vbi and > > mpeg. > > So, moving it require more care. > > Err, you're right, I meant saa7134_input_init1() and not > saa7134_hwinit1(), copy-and-paste error. Sorry for adding more > confusion where it really wasn't needed... >
both attempts of Jean will work. If we are only talking about moving input_init, only that Jean did suggest initially, it should work, since only some GPIOs for enabling remote chips are affected. I can give the crappy tester, but don't have such a remote, but should not be a problem to trigger the GPIOs later. Cheers, Hermann -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
