Hi Eugen:

In function isc_interrupt(), variable "isc_intsr" and "isc_intmask"
(drivers/media/platform/atmel/atmel-isc-base.c)
could be uninitialized if regmap_read() fails and return -EINVAL .
However, they are used to decide the control flow later in the if
 statement, which is potentially unsafe.

We cannot simply return -EINVAL in isc_interrupt() because it is
out of the return type: irqreturn_t.

Thanks for your time to check this case.

-- 
Kind Regards,

Yizhuo Zhai

Computer Science, Graduate Student
University of California, Riverside

Reply via email to