On Wed, 12 Jun 2019 08:14:35 +0000 Jonas Karlman <jo...@kwiboo.se> wrote:
> On 2019-06-11 14:50, Philipp Zabel wrote: > > Rename the driver and all relevant identifiers from Rockchip to Hantro, > > as other Hantro IP based VPU implementations can be supported by the > > same driver. > > The RK3288 decoder is Hantro G1 based, the encoder is Hantro H1. > > The RK3288 has two VPU blocks that is described as a VPU combo in the > datasheet, > VPU1 (the G1) and a HEVC decoder (not sharing the Hantro G2 hw regs). > Similarly the RK3399 has two VPU blocks, VPU2 based on G1 but with > regs/fields re-ranged > and the RKVDPU (new generation of the HEVC block found in RK3288). > > How can we expose these secondary blocks once rockchip vpu driver has > transitioned > into a hantro driver? Should a new rockchip vpu driver be created for the > HEVC/RKVDEC blocks? Yes, if those are not Hantro IPs a new driver should be created. I'm currently working on providing generic m2m helpers for stateless codecs to limit the code duplication incurred by this split. The good thing is that it should also help shrink the code of the cedrus driver (and more generally all stateless codec drivers).
