Hello!
On 02/28/2019 02:06 PM, Geert Uytterhoeven wrote:
> devm_ioremap_resource() already prints an error message on failure, so
> there is no need to repeat that.
>
> Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be>
> ---
> drivers/media/platform/rcar_drif.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/platform/rcar_drif.c
> b/drivers/media/platform/rcar_drif.c
> index c417ff8f6fe548f3..d4efade7aea60e32 100644
> --- a/drivers/media/platform/rcar_drif.c
> +++ b/drivers/media/platform/rcar_drif.c
> @@ -1407,7 +1407,6 @@ static int rcar_drif_probe(struct platform_device *pdev)
> ch->base = devm_ioremap_resource(&pdev->dev, res);
> if (IS_ERR(ch->base)) {
> ret = PTR_ERR(ch->base);
> - dev_err(&pdev->dev, "ioremap failed (%d)\n", ret);
> return ret;
No need to use 'ret' now -- how about merging the assignment and *return*?
> }
> ch->start = res->start;
>
MBR, Sergei
